Skip to content

Add binary content type handling in cache interceptor #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 11, 2025

Conversation

conico974
Copy link
Contributor

Introduce support for handling binary content types in the cache interceptor, along with tests for route type retrieval from the cache.

Copy link

changeset-bot bot commented Aug 11, 2025

🦋 Changeset detected

Latest commit: 49be16b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 28.11% 2779 / 9886
🔵 Statements 28.11% 2779 / 9886
🔵 Functions 55.68% 147 / 264
🔵 Branches 75.35% 688 / 913
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/core/routing/cacheInterceptor.ts 89.91% 66.66% 100% 89.91% 45, 56-62, 76-77, 121, 175-176, 197-199, 204-205, 216-218, 228-229, 306-307
Generated in workflow #1427 for commit 49be16b by the Vitest Coverage Report Action

Copy link

pkg-pr-new bot commented Aug 11, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@954

commit: 49be16b

Copy link
Contributor

@khuezy khuezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@conico974 conico974 merged commit 99d8909 into main Aug 11, 2025
3 checks passed
@conico974 conico974 deleted the conico/interceptor-route branch August 11, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants